How do you go about constructive criticism of code?
TJ Johnson

TJ Johnson @masterroshan

Joined:
May 15, 2020

How do you go about constructive criticism of code?

Publish Date: Oct 17 '20
1 2

Comments 2 total

  • TJ Johnson
    TJ JohnsonOct 17, 2020

    There's a camp that you should not give unsolicited criticism. But sometimes problems that go unchecked can end up being your responsibility. How do you reconcile?

  • Alain Van Hout
    Alain Van HoutOct 17, 2020

    Three simple ways to phrase these things is:

    • As a question: What if we ...? How about changing this to ...? Might X also work here?
    • As a further improvement: This approach will work even better if we ... We could also do X here, so that
    • Say it from the point of the team: all the use of 'we' in the previous items

    Combining the three generally works best in my own experience.

Add comment