[RESOLVED] What's wrong Forem/Dev #3
Wj

Wj @wjplatformer

About: e

Location:
Singapore
Joined:
Jun 28, 2022

[RESOLVED] What's wrong Forem/Dev #3

Publish Date: Jul 6 '22
7 6

I'm always doing this...

Well, this time, it's concerning icons...

The location icon!

Is not aligned to the actual text of the location. Yes.

Screenshot:

logo issue

Is it time for ME to do a PR?

Yep. But maybe I can try in teh future. Cos an awesome guy keeps on fixing these issues.

Comments 6 total

  • Andrew Bone
    Andrew BoneJul 6, 2022

    Fixed it already, it was a typo on my part.

    Fix typo related to recent PR #18046

    Link2Twenty avatar
    Link2Twenty posted on

    What type of PR is this? (check all applicable)

    • [ ] Refactor
    • [ ] Feature
    • [x] Bug Fix
    • [ ] Optimization
    • [ ] Documentation Update

    Description

    Yikes, I made a typo. I missed a /

    Related Tickets & Documents

    N/A

    QA Instructions, Screenshots, Recordings

    N/A

    UI accessibility concerns?

    N/A

    Added/updated tests?

    • [ ] Yes
    • [x] No, and this is why: visual update
    • [ ] I need help with writing tests

    [optional] Are there any post deployment tasks we need to perform?

    N/A

    [optional] What gif best describes this PR or how it makes you feel?

    embarrassed

    View on GitHub
    • Wj
      WjJul 6, 2022

      Wow. How are you so fast... and how'd you manage to read through all the scripts? Thanks, anyways.

      • Andrew Bone
        Andrew BoneJul 6, 2022

        I've been involved with this code base for a while so I know my way around 🙂

        • Wj
          WjJul 6, 2022

          Wow.

  • Wj
    WjJul 7, 2022

    coughs out blood 100 views in 5 hours...

Add comment